-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Remove duplicate title in individual summaries #89
🩹 Remove duplicate title in individual summaries #89
Conversation
@tusharnankani have a look and merge of looks fine to you as well |
@KartikSoneji @HarshKapadia2 requesting review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright. Thank you, Sreekaran!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just realised, this doesn't actually fix the duplicate title in the individual summary page. |
@KartikSoneji what do you mean? |
Ah damn, okay. In #71, the issue is to remove the redundant |
I see what it is - The first title comes from the individual-summary.adoc line 1. The second is from combined-summary-template.adoc line 1. Can someone confirm that the only purpose of the combined summary template is to serve inside the individual summary page? I can delete either and send in a PR, but deleting the one in the template might have unintended consequences if it also serves elsewhere. |
No. The combined summary template is also used to build, well, the combined summary. The fix will be a bit more involved with this one, I'll leave a comment with more details on the issue. |
Fixes #71