Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11327: Fix tooltip issue with Grouped Columns and increment version #437

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Oct 29, 2024

What was happening

  • There was an issue where the column headers displayed incorrect tooltip content when using grouped columns in a Grid:

What was done

  • Improved the validation about the tooltip method to be called on the internal event handler _onMouseEnter(e) because if the Column Header is from a Group Column, we need to use a different approach than the regular header.
  • We can check if the current target is a ColumnGroup by checking its CSS class wj-colgroup and, if there is no binding and the number of columns inside ColumnGroup > 0 or if the number of columnGroups inside ColumnGroup > 0.

Test Steps

  1. Go to a screen with two Grids, one with Grouped Columns and another without
  2. On the one with Grouped Columns hover all Column Headers and check that the tooltip content is the expected
  3. Repeat the same steps for the one without Grouped Columns for regression checks

Screenshots

  • Issue:

ToolttipGroupHeaderIssues

  • Fixed Issue:

TooltipGroupedColumnsIssueFixed

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint

@gnbm gnbm added the bug Something isn't working label Oct 29, 2024
@gnbm gnbm requested a review from a team as a code owner October 29, 2024 13:19
Copy link

sonarcloud bot commented Oct 31, 2024

@gnbm gnbm requested a review from BenOsodrac October 31, 2024 09:16
@gnbm gnbm merged commit 5fc3a5d into dev Oct 31, 2024
13 checks passed
@gnbm gnbm deleted the ROU-11327 branch October 31, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants