Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: simple land-sea mask generation #1005

Closed
lee1043 opened this issue Dec 15, 2023 · 1 comment · Fixed by #1006
Closed

[Feature]: simple land-sea mask generation #1005

lee1043 opened this issue Dec 15, 2023 · 1 comment · Fixed by #1006

Comments

@lee1043
Copy link
Contributor

lee1043 commented Dec 15, 2023

Is your feature request related to a problem?

Bringing in the land-sea mask generation capability that was built using regionmask into the PMP, unless it will be implemented to xcdat.

Describe the solution you'd like

The working code is described here: xCDAT/xcdat#576

Describe alternatives you've considered

Using pcmdi_utils have been considered as an alternative place to host such capabilities, but currently one of its dependencies, global-land-mask, is only available through pip, complicating the conda installation process.

Additional context

Hosting this capability will also help addressing #1004 and potential issues from other similar codes.

@lee1043 lee1043 self-assigned this Dec 15, 2023
@lee1043 lee1043 linked a pull request Dec 16, 2023 that will close this issue
4 tasks
@lee1043
Copy link
Contributor Author

lee1043 commented Apr 9, 2024

Just to leave a note:

The apply_landmask function is newly added which include create_land_sea_mask by using either of pcmdi method or regionmask.

By default apply-landmask is more strict in removing coastline grid, which tend to remove more of coastline grids.

Related test also can be found at: xCDAT/xcdat#613 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant