509 pjg clim departures #523
Conversation
|
@doutriaux1 @durack1 I don't understand what checks have failed here. Can one of you check and merge this so that I can close several issues and build on this? |
|
I need to merge master in, and we still have this issue that I need to explore with Denis
C.
From: gleckler1 <[email protected]>
Reply-To: PCMDI/pcmdi_metrics <[email protected]>
Date: Wednesday, January 3, 2018 at 5:06 PM
To: PCMDI/pcmdi_metrics <[email protected]>
Cc: "Doutriaux, Charles" <[email protected]>, Mention <[email protected]>
Subject: Re: [PCMDI/pcmdi_metrics] 509 pjg clim departures (#523)
@doutriaux1<https://github.com/doutriaux1> @durack1<https://github.com/durack1> I don't understand what checks have failed here. Can one of you check and merge this so that I can close several issues and build on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#523 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACpw8QncMpdICyL_X3zMUpnUFiCASFOvks5tHCPugaJpZM4RRPFN>.
|
|
@doutriaux1 @durack1 .... more than a week... we need to be in a mode where simple merges such as this can turn around in less than a day... why are we not there? |
|
@gleckler1 why did you add the JsoonClass ipynb in that PR? Why did portrait notebook changed? |
|
@gleckler1 master passes test suite, so in theory we shoudln't even start reviewing until test passes. Please merge master into your branch. |
|
@gleckler1 do we want this one? |
|
@doutriaux1 funny you should ask, I was just looking at this yesterday. The answer for the two file changes is yes. I don't know what the notebook is - I will take a look at it. |
|
@gleckler1 I merged master in this one as well and fixed conflicts. |
|
@gleckler1 in effort of housekeeping, could you please check what's the status of this branch? Is this PR still valid? |
|
@gleckler1 could you remind me if this PR is still valid? |
|
@gleckler1 I guess this PR is inactive and should be okay to close it without merging, is that correct? |
|
@gleckler1 I changed this PR to draft status. It looks like key addition in this PR is to add "rms_devzm_xy","rms_devam_xy" statistics for the mean climate metrics. I will consider adding them to the xcdat version mean climate later. |
|
I am closing this PR and will reopen a new one once it is ready for #897. |
@doutriaux1 @durack1 All intended changes are to mean_climate_metrics_calculations.py
... not sure what jupyter stuff is coming from... it can be removed before merging if that make sense