Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caution: using empty lists as default arguments may cause unintended side effects! #3

Open
osmart opened this issue Apr 5, 2023 · 1 comment

Comments

@osmart
Copy link

osmart commented Apr 5, 2023

In Python using an empty list as a default argument to a function or method is a mistake.
For a great explanation of why please see https://nikos7am.com/posts/mutable-default-arguments/

pdbecif uses empty lists as default arguments extensively for instance

def parse(
self,
file_path,
ignoreCategories=[],
preserve_token_order=False,
onlyCategories=[],
):

If ignoreCategories or onlyCategories are used then they may well be reused on subsequent calls.

@osmart
Copy link
Author

osmart commented Apr 5, 2023

Is worth fixing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant