Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distance_to_source #35

Open
aalbino2 opened this issue Nov 13, 2024 · 4 comments
Open

distance_to_source #35

aalbino2 opened this issue Nov 13, 2024 · 4 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@aalbino2
Copy link
Member

Harmonize the PVDSampleParameters quantity to what is implemnented in this use case

@aalbino2 aalbino2 self-assigned this Nov 13, 2024
@aalbino2 aalbino2 linked a pull request Nov 20, 2024 that will close this issue
@aalbino2
Copy link
Member Author

@oliverbierwagen I have a question regarding the source_to_substrate_distance

Is it supposed to be an average distance from all the substrates present on a substrate holder?

Is it always the center of the substrate holder?

@oliverbierwagen
Copy link
Collaborator

@oliverbierwagen I have a question regarding the source_to_substrate_distance

Is it supposed to be an average distance from all the substrates present on a substrate holder?

Is it always the center of the substrate holder?

It is distance to center of substrate holder.

@aalbino2
Copy link
Member Author

okay, thanks @oliverbierwagen!

@aalbino2
Copy link
Member Author

I will leave back this issue and keep this metadata into the Source class.

In the community plugin, it is placed inside the SampleParameters class, for each of the substrates present on the holder.

In the future, we can implement a normalization putting together the holder-source distance and the positions of the substrates in the holder to have a correct indication of substrate-source distance for each substrate.

Also, relative directions of the source and substrate normals can be normalized and filled, but for this we need to extend a bit the position datamodel in the community plugin.

@aalbino2 aalbino2 added the wontfix This will not be worked on label Nov 21, 2024
@aalbino2 aalbino2 removed a link to a pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants