fix: apply SCV's audit suggested changes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on has been settled; remove rewards_basket from state as it will always be outdated, pass it on settle auction as input parameter now
- added a limit so only can transfer N/20 tokens at a time - iterated via REWARD tokens.
…ctor & validate balances are greater than 0
… winning the auction
…& use constant CONTRACT_NAME on migrate entry point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
join_poolto make sure the previous auction has been settled.rewards_basketfrom state as it will always be outdated, pass it onsettle_auctionas input parameter now by the whitelisted address.