You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been moving us toward having functionality for different types of elements inside Articles inside their own classes rather than having such a monumental Article class.
This will help in a lot of ways but the biggest things have to do with bringing new people into the codebase. Specifically by localising the functionality, it'll be easier for people to trace down bugs, know where to introduce new functionality, test, write documentation for, &c..
So I figured that we should start compiling a list of element classes that should be created as we realise that they exist in the article itself:
Contributor(base_class, raise NotImplementedErrors in init.py)
Author(Contributor)
Editor(Contributor)
Counts (maybe… not sure)
In the case of doi, url and filename the methods currently used to transform them could be contained within the classes, eliminating the need for the transformations scripts and tying the validation directly to the particular kinds of elements.
And there may be others but those are the ones that jump out at me at the moment.
I've been moving us toward having functionality for different types of elements inside
Article
s inside their own classes rather than having such a monumentalArticle
class.This will help in a lot of ways but the biggest things have to do with bringing new people into the codebase. Specifically by localising the functionality, it'll be easier for people to trace down bugs, know where to introduce new functionality, test, write documentation for, &c..
So I figured that we should start compiling a list of element classes that should be created as we realise that they exist in the article itself:
In the case of doi, url and filename the methods currently used to transform them could be contained within the classes, eliminating the need for the transformations scripts and tying the validation directly to the particular kinds of elements.
And there may be others but those are the ones that jump out at me at the moment.
@eseiver @sbassi
The text was updated successfully, but these errors were encountered: