Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style guideline #1

Open
VoigtSebastian opened this issue Apr 9, 2021 · 1 comment
Open

Style guideline #1

VoigtSebastian opened this issue Apr 9, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@VoigtSebastian
Copy link
Contributor

General

  • Why is this an issue? Because I want feedback and everybody can easily tell my why this guide is wrong and everything should be done differently
  • Shouldn't we fork the project an work on this fork? Probably yes, but we are all somehow lazy, aren't we?

Branches

A personal branch should always start with you username. Every branch that does not have a leading username is a special branch that is used to synchronize work (main, development and feature-branches). Where main is the branch tracking the current release and development is used to collect features for release.

If you are working on a feature or fix a bug that is part of an issue, you create a branch that follows the form of username/issue/issue-id. This way it is clear that you are working on a specific issue.
If you work on something that is not part of an issue (shame on you), the naming-scheme should be username/information-about-branch. The information-about-branch should describe the work you are doing correctly and clearly.

If multiple people work on a single issue, a special branch is created that has the form issue/issue-id. This branch is used for synchronization and then merged into development.

Pull-Requests

You shall not merge into main, development or a feature-branch without a pr!
It is annoying to have new commits without information about what they do, do a pull-request and assign the correct people to it.

If you are working on an issue, reference the issue in the pull-request. Have look at the official documentation about how to do this..

Clean up after a successful merge. GitHub makes it easy to remove merged feature branches, if they are not used anymore, delete them.

Commits

If you want information about commit messages.

@VoigtSebastian VoigtSebastian added the documentation Improvements or additions to documentation label Apr 9, 2021
@VoigtSebastian VoigtSebastian pinned this issue Apr 9, 2021
@hyerex hyerex unpinned this issue Apr 29, 2021
@LugsoIn2
Copy link
Contributor

LugsoIn2 commented May 7, 2021

Anyone can look over the pull request and test it. The first person then comments on it and decides ok or not. If a second person then looks at it and decides everything is ok, this person can merge.

@LugsoIn2 LugsoIn2 closed this as completed May 7, 2021
@LugsoIn2 LugsoIn2 reopened this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants