Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hfun agreement issues #107

Open
jmlarson1 opened this issue Sep 25, 2023 · 1 comment
Open

hfun agreement issues #107

jmlarson1 opened this issue Sep 25, 2023 · 1 comment

Comments

@jmlarson1
Copy link
Collaborator

Something is different with the macOS builds on GitHub actions. For some of our hfuns, the manifold sampling tests error reporting:

hfun values don't agree when the function is re-called with the same inputs

https://github.com/POptUS/IBCDFO/actions/runs/6304767035

These issues don't appear with ubuntu.

We can either relax the conditions in
https://github.com/POptUS/IBCDFO/blob/main/manifold_sampling/py/call_user_scripts.py
or drop macOS from our GitHub actions.

Thoughts @mmenickelly ?

@jared321
Copy link
Collaborator

While I'm not Matt, my (unsolicited) two cents is to always test on macOS as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants