-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular model building and model updating #125
base: develop
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 9195731513Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to change the order of the formquad arguments to highlight how we hope future model-building routines would be structured? (In particular, vf is non-optional?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API has not changed, default behaviors are to set model_builder to @formquad and to set Ffun_nargout to 1.
Outstanding problems and things to think about:
- Currently, every model_builder is not even seeing the aux part of the eval_data structure. What I want to do is to have the whole eval_data be passed in so the arbitrary model_builder can have whatever it needs. What this would require, of course, is that formquad immediately just read off the F field of the eval_data and then proceed like usual. Is that okay with us? It's not too unsettling to me.
- Note that we weren't previously using Prior.X_init and Prior.F_init correctly when nfs > 0. Should this be a separate PR? (Yes, but I already did it here) Do we have a test of a nonempty Prior structure in place?
- If we keep going down this road, the output arguments and prepare_outputs_before_return will also want to clean up and output the whole eval_data structure (both the F and aux field)
Don't pull this in until we discuss it, but I wanted to see a full PR report