diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 37cfe77..304ae26 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -12,7 +12,16 @@ repos: rev: v14.0.0 hooks: - id: clang-format +- repo: https://github.com/psf/black + rev: 23.1.0 + hooks: + - id: black - repo: https://github.com/ahans/cmake-format-precommit rev: 8e52fb6506f169dddfaa87f88600d765fca48386 hooks: - id: cmake-format +- repo: https://github.com/pycqa/isort + rev: 5.12.0 + hooks: + - id: isort + args: ["--profile", "black", "--filter-files"] diff --git a/ros/launch/offline_node.launch.py b/ros/launch/offline_node.launch.py index 371d8bb..bd66551 100644 --- a/ros/launch/offline_node.launch.py +++ b/ros/launch/offline_node.launch.py @@ -4,14 +4,13 @@ import launch from ament_index_python.packages import get_package_share_directory from launch import LaunchDescription -from launch.actions import OpaqueFunction +from launch.actions import DeclareLaunchArgument, OpaqueFunction from launch.conditions import IfCondition from launch.launch_description_sources import ( get_launch_description_from_python_launch_file, ) from launch.substitutions import LaunchConfiguration from launch_ros.actions import Node -from launch.actions import DeclareLaunchArgument def _generate_launch_description(context: launch.LaunchContext, *args, **kwargs): diff --git a/ros/launch/online_node.launch.py b/ros/launch/online_node.launch.py index 01c0a2a..d0323b1 100644 --- a/ros/launch/online_node.launch.py +++ b/ros/launch/online_node.launch.py @@ -11,7 +11,9 @@ def generate_launch_description(): - use_sim_time = LaunchConfiguration("use_sim_time", default=(os.getenv("SIMULATION") == "true")) + use_sim_time = LaunchConfiguration( + "use_sim_time", default=(os.getenv("SIMULATION") == "true") + ) tf_timeout = LaunchConfiguration( "tf_timeout", default=PythonExpression(["'0.1' if ", use_sim_time, " else '0.0'"]), @@ -31,7 +33,8 @@ def generate_launch_description(): ], parameters=[ # KISS-ICP configuration - get_package_share_directory("kinematic_icp") + "/config/kinematic_icp_ros.yaml", + get_package_share_directory("kinematic_icp") + + "/config/kinematic_icp_ros.yaml", { # Input topic, is not a remap to marry API with offline node "input": LaunchConfiguration("lidar_topic"),