From aeb11216e70dd0e4cce76c7cc9827da2b9a4f2f1 Mon Sep 17 00:00:00 2001 From: Benedikt Mersch Date: Fri, 8 Mar 2024 14:30:54 +0100 Subject: [PATCH 1/5] Add defaults and executable --- python/kiss_icp/config/parser.py | 2 +- python/pyproject.toml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/python/kiss_icp/config/parser.py b/python/kiss_icp/config/parser.py index 558a01eb..7b21122d 100644 --- a/python/kiss_icp/config/parser.py +++ b/python/kiss_icp/config/parser.py @@ -90,7 +90,7 @@ def load_config( return config -def write_config(config: KISSConfig, filename: str): +def write_config(config: KISSConfig = KISSConfig(), filename: str = "config.yaml"): with open(filename, "w") as outfile: try: yaml = importlib.import_module("yaml") diff --git a/python/pyproject.toml b/python/pyproject.toml index 76f7cd25..a8ef7e44 100644 --- a/python/pyproject.toml +++ b/python/pyproject.toml @@ -63,6 +63,7 @@ visualizer = [ [project.scripts] kiss_icp_pipeline = "kiss_icp.tools.cmd:run" +kiss_icp_config = "kiss_icp.config.parser:write_config" [project.urls] Homepage = "https://github.com/PRBonn/kiss-icp" From 6036d263a1ace2741a9c37f8c508de8e91dfed70 Mon Sep 17 00:00:00 2001 From: Benedikt Mersch Date: Fri, 8 Mar 2024 14:36:50 +0100 Subject: [PATCH 2/5] Add to Python readme --- python/README.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/python/README.md b/python/README.md index 09725043..2cffa21f 100644 --- a/python/README.md +++ b/python/README.md @@ -54,6 +54,16 @@ kiss_icp_pipeline --help This should print the following help message: ![out](https://user-images.githubusercontent.com/21349875/193282970-25a400aa-ebcd-487a-b839-faa04eeca5b9.png) +### Config + +You can generate a default `config.yaml` by typing + +```sh +kiss_icp_config +``` + +Now, you can modify the parameters and pass the file to the `--config` option when running the `kiss_icp_pipeline`. + ### Install Python API (developer mode) If you plan to modify the code then you need to setup the dev dependencies, luckily, the only real From bb76fb397ef85ed8008b3d10399960c8d375a639 Mon Sep 17 00:00:00 2001 From: Benedikt Mersch Date: Fri, 8 Mar 2024 23:39:07 +0100 Subject: [PATCH 3/5] Update python/pyproject.toml Co-authored-by: Ignacio Vizzo --- python/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/pyproject.toml b/python/pyproject.toml index a8ef7e44..c6270ddc 100644 --- a/python/pyproject.toml +++ b/python/pyproject.toml @@ -63,7 +63,7 @@ visualizer = [ [project.scripts] kiss_icp_pipeline = "kiss_icp.tools.cmd:run" -kiss_icp_config = "kiss_icp.config.parser:write_config" +kiss_icp_dump_config = "kiss_icp.config.parser:write_dump_config" [project.urls] Homepage = "https://github.com/PRBonn/kiss-icp" From 416b07c629ad4d034993f1b2b1a342d19e2feed6 Mon Sep 17 00:00:00 2001 From: Benedikt Mersch Date: Fri, 8 Mar 2024 23:39:13 +0100 Subject: [PATCH 4/5] Update python/README.md Co-authored-by: Ignacio Vizzo --- python/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/README.md b/python/README.md index 2cffa21f..54fb4abf 100644 --- a/python/README.md +++ b/python/README.md @@ -59,7 +59,7 @@ This should print the following help message: You can generate a default `config.yaml` by typing ```sh -kiss_icp_config +kiss_icp_dump_config ``` Now, you can modify the parameters and pass the file to the `--config` option when running the `kiss_icp_pipeline`. From 51bee698b1c9ded2ce28537a4350b07219726f9e Mon Sep 17 00:00:00 2001 From: Benedikt Mersch Date: Fri, 8 Mar 2024 23:39:18 +0100 Subject: [PATCH 5/5] Update python/kiss_icp/config/parser.py Co-authored-by: Ignacio Vizzo --- python/kiss_icp/config/parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/kiss_icp/config/parser.py b/python/kiss_icp/config/parser.py index 7b21122d..bf7afa7b 100644 --- a/python/kiss_icp/config/parser.py +++ b/python/kiss_icp/config/parser.py @@ -90,7 +90,7 @@ def load_config( return config -def write_config(config: KISSConfig = KISSConfig(), filename: str = "config.yaml"): +def write_config(config: KISSConfig = KISSConfig(), filename: str = "kiss_icp.yaml"): with open(filename, "w") as outfile: try: yaml = importlib.import_module("yaml")