Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkmon: GTask finalized without ever returning (using g_task_return_*()) #709

Open
sidt4 opened this issue Jan 9, 2024 · 2 comments · May be fixed by #718 or #756
Open

pkmon: GTask finalized without ever returning (using g_task_return_*()) #709

sidt4 opened this issue Jan 9, 2024 · 2 comments · May be fixed by #718 or #756

Comments

@sidt4
Copy link
Contributor

sidt4 commented Jan 9, 2024 

$ pkmon
...
...
(pkmon:4086): GLib-GIO-CRITICAL **: 17:29:46.168: GTask 0x55aa9147cf60 (source object: 0x55aa9147aa30, source tag: 0x7f1b39a3b1c0) finalized without ever returning (using g_task_return_*()). This potentially indicates a bug in the program.
/8_edaceddb	allow_cancel 1
/8_edaceddb	percentage   -1
/8_edaceddb	role         search-file
/8_edaceddb	sender       /usr/bin/gnome-software
/8_edaceddb	status       wait
@sidt4
Copy link
Contributor Author

sidt4 commented Feb 27, 2024

Still getting these, making pkmon a bit annoying to use.

(pkmon:78935): GLib-GIO-CRITICAL **: 15:57:17.241: GTask 0x55bec43c7bf0 (source object: 0x55bec30a0a30, source tag: 0x7fa2f7dba1c0) finalized without ever returning (using g_task_return_*()). This potentially indicates a bug in the program.

(pkmon:78935): GLib-GIO-CRITICAL **: 15:57:17.241: GTask 0x55bec43ecbe0 (source object: 0x55bec30a0a30, source tag: 0x7fa2f7dba1c0) finalized without ever returning (using g_task_return_*()). This potentially indicates a bug in the program.

(pkmon:78935): GLib-GIO-CRITICAL **: 15:57:17.241: GTask 0x55bec43a1ba0 (source object: 0x55bec30a0a30, source tag: 0x7fa2f7dba1c0) finalized without ever returning (using g_task_return_*()). This potentially indicates a bug in the program.

(pkmon:78935): GLib-GIO-CRITICAL **: 15:57:17.241: GTask 0x55bec4302530 (source object: 0x55bec30a0a30, source tag: 0x7fa2f7dba1c0) finalized without ever returning (using g_task_return_*()). This potentially indicates a bug in the program.

@tintou: can you please take a look ?

@tintou
Copy link
Collaborator

tintou commented Feb 29, 2024

I've looked at it and is not really a big issue per-se (other than producing a verbose message) but requires a bit refactoring

@tintou tintou linked a pull request Mar 6, 2024 that will close this issue
Open
sidt4 added a commit to sidt4/PackageKit that referenced this issue May 19, 2024
@sidt4
pk-client: Fix pkmon gtask warning caused by PkClient refcount issue
25668a0 
Fixes 'GTask finalized without ever returning (using
g_task_return_*())' warning message while running `pkmon` and gives
the proper output.

This was caused because `PkClientState` was finalized incorrectly,
causing the state's gtask object to be finalized causing the warning.

Fixes: PackageKit#709
sidt4 added a commit to sidt4/PackageKit that referenced this issue May 19, 2024
@sidt4
pk-client: Fix GTask warning caused by PkClientState refcount issue
b9609ee 
Fixes the following warning message while running 'pkmon' and gives
the proper output.

"GTask finalized without ever returning (using g_task_return_*())"

This was caused because 'PkClientState' was finalized incorrectly,
causing the state's 'GTask' object to be finalized before expected,
causing the warning.

Fixes: PackageKit#709
@sidt4 sidt4 linked a pull request May 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tintou @sidt4