Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typo] Naming convention in dispatcher classes #21

Open
AshishSardana opened this issue Nov 25, 2024 · 0 comments
Open

[typo] Naming convention in dispatcher classes #21

AshishSardana opened this issue Nov 25, 2024 · 0 comments

Comments

@AshishSardana
Copy link

AshishSardana commented Nov 25, 2024 •
edited
Loading

Is there a reason why ChunkingDispatcher has an attribute cleaning_factory=ChunkingHandlerFactory instead of chunking_factory=ChunkingHandlerFactory ? I'm referring to this LOC.

The same naming convention is used for EmbeddingDispatcher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AshishSardana