Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SCM bootstrap options #80

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat: Add SCM bootstrap options #80

merged 1 commit into from
Sep 19, 2024

Conversation

slawomir-kaczmarek
Copy link
Contributor

Description

The change adds SCM bootstrap options to examples. They are commented out and can be used on-demand.

Motivation and Context

Introduce bootstrapping to Strata Cloud Manager.

How Has This Been Tested?

Code was deployed in the lab and verified if successfully onboarded to SCM.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@slawomir-kaczmarek slawomir-kaczmarek requested a review from a team as a code owner September 19, 2024 07:20
Copy link
Contributor

@lstadnik lstadnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstadnik
Copy link
Contributor

lstadnik commented Sep 19, 2024

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10937990996
Job result: SUCCESS

@slawomir-kaczmarek slawomir-kaczmarek self-assigned this Sep 19, 2024
@slawomir-kaczmarek slawomir-kaczmarek linked an issue Sep 19, 2024 that may be closed by this pull request
@lstadnik lstadnik merged commit 3c1e010 into main Sep 19, 2024
82 checks passed
@lstadnik lstadnik deleted the scm-bootstrap branch September 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SCM Bootstrap Support
2 participants