Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all credentials to db and have pbot pull creds from there #40

Open
5 tasks
mhijazi1 opened this issue Feb 16, 2017 · 2 comments
Open
5 tasks

Move all credentials to db and have pbot pull creds from there #40

mhijazi1 opened this issue Feb 16, 2017 · 2 comments

Comments

@mhijazi1
Copy link
Contributor

Currently all creds are pulled from env variables/files on the instance running pantherbot. This should be changed. Pantherbot should only need to pull one set of creds for the DB, connect to the db, and pull all creds needed from there.

  • Create DB table
  • Load Creds into DB (This needs to be done by an admin)
  • Pull Necessary Creds from DB
  • Have DB creds pulled from env variable
  • Set DB cred env variable in aws (this needs to be done by @mhijazi1)
@mhijazi1 mhijazi1 self-assigned this Feb 16, 2017
@ferrerluis
Copy link
Member

Even better @mhijazi1! What if you keep a .env.enc file with all credentials committed in the repo, then a single env variable to decrypt the file. This "master key" can then be shared across maintainers and injected in the instances that run Pbot.

Thoughts?

@ferrerluis
Copy link
Member

In fact, Rails 5.1 included this sort of behavior in the framework. I know this is not Rails, but we could do something similar!

http://weblog.rubyonrails.org/2017/2/23/Rails-5-1-beta1/

@mhijazi1 mhijazi1 removed their assignment Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants