Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling FireworkExplodeEvent does not remove the Firework entity #12266

Closed
Esophose opened this issue Mar 11, 2025 · 0 comments · Fixed by #12268
Closed

Cancelling FireworkExplodeEvent does not remove the Firework entity #12266

Esophose opened this issue Mar 11, 2025 · 0 comments · Fixed by #12268
Labels
scope: api status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.21.4 Game version 1.21.4

Comments

@Esophose
Copy link
Contributor

Esophose commented Mar 11, 2025

Expected behavior

As per the javadocs, setting the FireworkExplodeEvent to cancelled = true should remove the firework entity

Observed/Actual behavior

The firework entity remains, and continues to call the FireworkExplodeEvent for every tick that it continues living. It seems to live an arbitrary amount of ticks longer.

Steps/models to reproduce

@EventHandler(priority = EventPriority.HIGH, ignoreCancelled = true)
public void onFireworkExplode(FireworkExplodeEvent event) {
    event.setCancelled(true);
    Bukkit.getServer().getLogger().warning("kaboom!");
}

Plugin and Datapack List

> plugins
[23:25:56 INFO]: ℹ Server Plugins (1):
[23:25:56 INFO]: Bukkit Plugins:
[23:25:56 INFO]:  - RoseParticles
> datapack list
[23:25:58 INFO]: There are 3 data pack(s) enabled: [vanilla (built-in)], [file/bukkit (world)], [paper (built-in)]
[23:25:58 INFO]: There are no more data packs available

Paper version

This server is running Paper version 1.21.4-207-main@1a7288a (2025-03-09T18:15:59Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are running the latest version

Other

https://gyazo.com/32512995d80672ca2ceaf5a5b32a9e29

@papermc-sniffer papermc-sniffer bot added the version: 1.21.4 Game version 1.21.4 label Mar 11, 2025
@Lulu13022002 Lulu13022002 added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. scope: api and removed status: needs triage labels Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: api status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. version: 1.21.4 Game version 1.21.4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants