Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inversed visual fire & lock fire ticks #12084

Open
NonSwag opened this issue Feb 8, 2025 · 1 comment · May be fixed by #12303
Open

Inversed visual fire & lock fire ticks #12084

NonSwag opened this issue Feb 8, 2025 · 1 comment · May be fixed by #12303

Comments

@NonSwag
Copy link
Contributor

NonSwag commented Feb 8, 2025

Is your feature request related to a problem?

Currently, we have the ability to set an entity visually on fire without it being actually burning
but the way visual fire works, it is not possible to disable visual fire if the entity is really burning

Describe the solution you'd like.

Internally, the visualFire field could use a nullable Boolean object and default to null and make the entity burn if true
not burn if false
and send the actual fire state when null
I understand this will cause problems with existing plugins that utilize this method, other suggestions are more than welcome

Describe alternatives you've considered.

Other

Also, I would like to suggest adding a lockFireTicks method to be able to make entities burn or not start burning as long as the ticks are locked

@NonSwag
Copy link
Contributor Author

NonSwag commented Feb 8, 2025

I also just noticed that the getMaxFireTicks is absolutely misleading
it returns the immunity ticks (1 for non player entities and 20 for players)
this should probably not only be clarified in the JD but maybe even a rename would be appropriate

@NonSwag NonSwag linked a pull request Mar 16, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant