Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impassible states shouldn't get extras #1258

Open
Idhrendur opened this issue Nov 15, 2021 · 1 comment
Open

Impassible states shouldn't get extras #1258

Idhrendur opened this issue Nov 15, 2021 · 1 comment
Labels
Milestone

Comments

@Idhrendur
Copy link
Member

Right now there's no check preventing them from getting factories, airbases, infrastructure bonuses, etc. This should not be.

(If working on this, do so from the NSB branch until it's fully merged, else it'll cause a merge conflict)

@Idhrendur Idhrendur added this to the 0.4 milestone Nov 15, 2021
@gawquon
Copy link
Member

gawquon commented Mar 25, 2022

This would seem to be a non-issue currently as the impassable states are all categorized as wasteland, which prevents most buildings from being built there. Forts/Air Bases/Infrastructure can all be built there but that is the case in vanilla as well.
The only potential oddity is that there can be resources in these states.

state={
	id=296
	name="STATE_296"
	resources={
		steel=1.000
	}
	impassable = yes

	history={
		owner = GER
		add_core_of = GER
	}

	provinces={
		1057 1140 1994 4191 7985 10104 10754 10785 12866 
	}
	manpower=515711
	buildings_max_level_factor=1.000
	state_category=wasteland

	local_supplies=10.0
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants