From ecc857da1c8e4ad46645928ce65ca8b7fb1f6016 Mon Sep 17 00:00:00 2001 From: racso Date: Wed, 30 Oct 2024 01:04:34 -0400 Subject: [PATCH 1/2] fix pnl calculation --- src/perps/index.ts | 7 +++---- src/perps/positions.ts | 11 +++++------ 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/perps/index.ts b/src/perps/index.ts index e8e200b..85e5d60 100644 --- a/src/perps/index.ts +++ b/src/perps/index.ts @@ -1,16 +1,15 @@ import Decimal from 'decimal.js'; -import { calculatePositionLeverage, getProfitOrLossInUsd } from './positions'; +import { calculatePositionLeverage, getProfitOrLossInUsd } from './positions'; import { Position } from '../interfaces/sdkTypes'; export class Perps { constructor() {} getProfitOrLossInUsd = ( - normalizedMarketPrice: number, + marketPrice: number, avgPrice: number, positionSize: number, - marketDecimals: number = 18, ): { totalProfitOrLoss: Decimal } => { - return getProfitOrLossInUsd(normalizedMarketPrice, avgPrice, positionSize, marketDecimals); + return getProfitOrLossInUsd(marketPrice, avgPrice, positionSize); }; calculatePositionLeverage = ({ diff --git a/src/perps/positions.ts b/src/perps/positions.ts index 75974c9..abb79bf 100644 --- a/src/perps/positions.ts +++ b/src/perps/positions.ts @@ -1,15 +1,15 @@ import Decimal from 'decimal.js'; export const getProfitOrLossInUsd = ( - normalizedMarketPrice: number, + marketPrice: number, avgPrice: number, positionSize: number, - marketDecimals: number = 18, ): { totalProfitOrLoss: Decimal } => { - const positionSizeDecimal = new Decimal(positionSize).div(Decimal.pow(10, marketDecimals)); - const avgPriceDecimal = new Decimal(avgPrice).div(Decimal.pow(10, marketDecimals)); - const profitOrLossPerToken = new Decimal(normalizedMarketPrice).minus(avgPriceDecimal); + const positionSizeDecimal = new Decimal(positionSize); + const avgPriceDecimal = new Decimal(avgPrice); + const profitOrLossPerToken = new Decimal(marketPrice).minus(avgPriceDecimal); const totalProfitOrLoss = positionSizeDecimal.times(profitOrLossPerToken); + return { totalProfitOrLoss }; }; @@ -41,4 +41,3 @@ export const calculatePositionLeverage = ({ return { positionLeverage: new Decimal(0) }; }; - From 8a453024dc463739849b056c11abb86fcafcf0f8 Mon Sep 17 00:00:00 2001 From: racso Date: Wed, 30 Oct 2024 01:07:44 -0400 Subject: [PATCH 2/2] bump version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e7c2410..ca7f83a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@parifi/sdk", - "version": "2.0.10-dev", + "version": "2.0.12-dev", "description": "Parifi SDK with common utility functions", "files": [ "dist",