feat: Settable LP Fee Recipient on ERC20CreatorV3 (#22)

* Settable LP Fee Recipient on `ERC20CreatorV3`

* test fee recipient set

* test setting lp fee recipient not party

* update test wording

Author: arr00

src/ERC20CreatorV3.sol

@@ -106,14 +106,16 @@ contract ERC20CreatorV3 is IERC721Receiver {
 
     /// @notice Creates a new ERC20 token, LPs it in a locked full range Uniswap V3 position, and distributes some of the new token to party members.
     /// @dev The party is assumed to be `msg.sender`
-    /// @param party The party to allocate this token to
+    /// @param party The party to allocate the token distribution to
+    /// @param lpFeeRecipient The address to receive the LP fee
     /// @param name The name of the new token
     /// @param symbol The symbol of the new token
     /// @param config Token distribution configuration. See above for additional information.
     /// @param tokenRecipientAddress The address to receive the tokens allocated for the token recipient
     /// @return token The address of the newly created token
     function createToken(
         address party,
+        address lpFeeRecipient,
         string memory name,
         string memory symbol,
         TokenDistributionConfiguration memory config,
@@ -245,7 +247,7 @@ contract ERC20CreatorV3 is IERC721Receiver {
 
         FeeRecipient[] memory recipients = new FeeRecipient[](1);
         recipients[0] = FeeRecipient({
-            recipient: payable(party),
+            recipient: payable(lpFeeRecipient),
             percentageBps: 10_000
         });
 

test/ERC20CreatorV3ForkTest.t.sol

@@ -86,6 +86,7 @@ contract ERC20CreatorV3ForkTest is Test {
         ERC20Votes token = ERC20Votes(
             address(
                 creator.createToken{value: eth}(
+                    address(party),
                     address(party),
                     "Leet H4x0rs",
                     "1337",

test/ERC20CreatorV3Test.t.sol

@@ -57,7 +57,8 @@ contract ERC20CreatorV3Test is Test, MockUniswapV3Deployer {
 
     function testCreatorV3_createToken(
         ERC20CreatorV3.TokenDistributionConfiguration memory tokenConfig,
-        uint256 ethForLp
+        uint256 ethForLp,
+        address feeRecipient
     ) public {
         tokenConfig.numTokensForDistribution = bound(
             tokenConfig.numTokensForDistribution,
@@ -104,6 +105,7 @@ contract ERC20CreatorV3Test is Test, MockUniswapV3Deployer {
         IERC20 token = IERC20(
             creator.createToken{value: ethForLp}(
                 address(party),
+                feeRecipient,
                 "My Test Token",
                 "MTT",
                 tokenConfig,
@@ -139,7 +141,7 @@ contract ERC20CreatorV3Test is Test, MockUniswapV3Deployer {
         assertEq(
             abi.encode(feeRecipients[0]),
             abi.encode(
-                FeeRecipient({recipient: address(party), percentageBps: 10_000})
+                FeeRecipient({recipient: feeRecipient, percentageBps: 10_000})
             )
         );
 

test/FeeCollector.t.sol

@@ -61,6 +61,7 @@ contract FeeCollectorTest is Test, MockUniswapV3Deployer {
         vm.prank(address(party));
         token = IERC20(
             creator.createToken{value: 10e18}(
+                address(party),
                 address(party),
                 "My Test Token",
                 "MTT",
@@ -128,4 +129,36 @@ contract FeeCollectorTest is Test, MockUniswapV3Deployer {
         );
         feeCollector.setPartyDaoFeeBps(newFeeBps);
     }
+
+    function test_createToken_lpFeeRecipientNotParty() external {
+        ERC20CreatorV3.TokenDistributionConfiguration
+            memory tokenConfig = ERC20CreatorV3.TokenDistributionConfiguration({
+                totalSupply: 1000000,
+                numTokensForDistribution: 500000,
+                numTokensForRecipient: 250000,
+                numTokensForLP: 250000
+            });
+
+        vm.deal(address(party), 10e18);
+        vm.prank(address(party));
+
+        creator.createToken{value: 10e18}(
+            address(party),
+            address(this),
+            "My Test Token",
+            "MTT",
+            tokenConfig,
+            address(this)
+        );
+        uint256 tokenId = MockUniswapNonfungiblePositionManager(
+            address(positionManager)
+        ).lastTokenId();
+
+        assertEq(feeCollector.getFeeRecipients(tokenId).length, 1);
+        assertEq(
+            feeCollector.getFeeRecipients(tokenId)[0].recipient,
+            address(this)
+        );
+        assertEq(feeCollector.getFeeRecipients(tokenId)[0].percentageBps, 1e4);
+    }
 }

test/FeeCollectorForked.t.sol

@@ -82,6 +82,7 @@ contract FeeCollectorForkedTest is Test {
         vm.recordLogs();
         token = IERC20(
             creator.createToken{value: 10e18}(
+                address(party),
                 address(party),
                 "My Test Token",
                 "MTT",