-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Top pathway hit #1425
Comments
UpdateGoal Primary use case Mockup Details Benefits:
Risks:
|
Python code to generate static images of PC pathways using the Syblars (https://pubmed.ncbi.nlm.nih.gov/36374853/ from Ugur Dogrusoz) Codehttps://gist.github.com/cannin/7e35f3fae274370bd0a70c7b1840c743 General Workflow
ExamplesThere is an upper limit nodes where the automated layout of SBGN is poor (~100 nodes???) Indexing of Static Content by GoogleGoogle depends on sitemaps to know what to index. Example from another project with 1700 pages that includes shows minimum to have static images indexed : https://discover.nci.nih.gov/rsconnect/cellminercdb/cell_lines/sitemap.xml Pages were slow to index at first, but everything eventually indexed; images tend to be even slower. |
I looked into using the existing services here in I was also thinking that also/instead we could pre-cache the pathway JSON data - PC HGNC GMT file says there are 3971 pathways. |
This looks like it: https://github.com/iVis-at-Bilkent/cytosnap/commits/master There are a number of new features there, including SVG export. It would be best to get those merged into the main Cytosnap lib. The main thing for now is SBGN support. @ugurdogrusoz, @hasanbalci -- are there any technical reasons why the general stylesheet / SBGN support could not be merged into the main lib? If not, we should aim to have features like this merged into the main Cytosnap lib so that it's maintained and compatible with the rest of the ecosystem going forward. |
@maxkfranz I think we also have some extension specific code in that fork, but I will open a PR with some basic features we added like ability of using other stylesheets or cy extensions and allowing export of image and node positions at the same time etc. |
Great. Thanks, @hasanbalci |
This first pass is running on our appsbeta.pathwaycommons.org. There's some good, bad and ugly, depending on the pathway size: GoodMitochondrial transcription termination | Reactome BadTP53 regulates transcription of additional cell cycle genes... Reactome UglyDirect p53 effectors | NCI-PID |
Improving the network layout generally would at least remove the 'ugly' (hairball) cases, even if they're still 'bad' (too large). This could motivate bumping up the priority of updated layout as a student project. We have lots of new layouts to try that didn't exist when the PC apps were built. |
By "bad", I meant from the standpoint of "how is this helpful or attractive to a user" - not so much if text labels are unreadable. So maybe better zooming, panning, and cropping (like google maps).
Sounds good. |
Yeah, the 'bad' is a balance. On the one hand, a zoomed in view is prettier. On the other hand, a full view is more what-you-see-is-what-you-get. Either way, better layout would be good. |
Just to re-up on my previous comment: #1425 (comment) The rendering and layouts are done in syblars: It would be nice (preferred) if we could just do all the rendering/snapping/layouts here. |
Just putting here: In regards to how my command line script generates names of images, an outstanding issue (@IgorRodchenkov) |
Goal
Feature a the top pathway search hit and include a visual preview (SBGN) when a query references at least one of the molecular participants.
Primary use case
Referral from public entity databases. In these cases, the query will be in the form of a (a) UniProt accession (referrer: UniProt) and/or b) HGNC symbol (referrer: GeneCards). The response should contain information necessary to populate a Feature Component for the pathway: name, source, #participants, and a URL pointing to an SBGN preview]
Restrictions & Limitations
Main concern is slowing down the "time to interactive" of the search, which degrades the user experience. Several potential bottlenecks:
Edge cases
Integrating with case where Biofactoid is contained in a Feature view (i.e. triggered when top search hit source is Biofactoid)
Notes
To reduce bottlenecks, might consider
a. Rendering and caching SBGN previews for all pathways instread of on-the-fly, which might also be useful in Google indexing
b. Have cPath2 index and return UnificationXrefs to bypass need to retrieve these on-the-fly information separately
The text was updated successfully, but these errors were encountered: