Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAJOR)/(MINOR) in merge commit message seems to be ignored #142

Open
GMZwinge opened this issue Mar 8, 2024 · 2 comments
Open

(MAJOR)/(MINOR) in merge commit message seems to be ignored #142

GMZwinge opened this issue Mar 8, 2024 · 2 comments

Comments

@GMZwinge
Copy link

GMZwinge commented Mar 8, 2024

When a branch is merged as a merge commit, the check for (MAJOR)/(MINOR) doesn't seem to be done on the message of the merge commit. It seems to be done only on the predecessors of the merge commit coming from the branch.

See for example the repo test-public-repo and the output of the workflow https://github.com/GMZwinge/test-public-repo/actions/workflows/test-semantic-version.yml for 3 different cases:

The repo is configured so that the PR title is used in the merged commit message. It uses the setting (x) Allow merge commits and the Default commit message set to Pull request title instead of the Default message. Using the Pull request title allows one to add (MAJOR) or (MINOR) to the PR title before merging to direct this action to increment major or minor version instead of patch.

@PaulHatch
Copy link
Owner

@GMZwinge, thanks for putting together the example repo. I have been quite sick in the past week or so and unable to do much dev, but I'll have a look when I get a chance.

@GMZwinge
Copy link
Author

GMZwinge commented Mar 25, 2024

@PaulHatch No worry, no hurry and take care of yourself. We have a workaround using the repo setting so that only squash and merge is allowed and merge commit is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants