Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make create release link work with other domains. #91

Open
Dill-Dall opened this issue Feb 1, 2023 · 2 comments
Open

Make create release link work with other domains. #91

Dill-Dall opened this issue Feb 1, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Dill-Dall
Copy link

Dill-Dall commented Feb 1, 2023

Cheers 👋

The action asserts that the domain is always github.com meaning enterprises with their own domains can't use this feature and get a 404.

To create a release for this version, go to https://github.com/some-repo/pring-boot-starter/releases/new?tag=v0.1.0&target=sjdlkasdl

#main.ts 

L:17 if (repository !== undefined) {
    core.info(`To create a release for this version, go to https://github.com/${repository}/releases/new?tag=${versionTag}&target=${currentCommit.split('/').slice(-1)[0]}`);
}
@Dill-Dall Dill-Dall changed the title Make create release link work with enterprise domains. Make create release link work with other domains. Feb 1, 2023
@PaulHatch PaulHatch added the enhancement New feature or request label Feb 5, 2023
@PaulHatch
Copy link
Owner

@ThomasDahll What does the URL for enterprise deployments look like? Perhaps just making this a relative URL would be enough.

@Dill-Dall
Copy link
Author

Dill-Dall commented Feb 5, 2023

Relative would probably be enough

We have "github.ourenterprisetitle.io/<enterprise-organization>/<repository>" instead of github.com/<repository>
But I bet that domain setup can vary(selfhosted vs cloud for instance), so would probably be best with just a relative domain like so
https://<domain+organization>/<repository...>
Would probably catch all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants