Replies: 1 comment
-
Locking since I ended up implementing this proposal in #81. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Context
@razgraf has recently given me feedback on 4.0.0-beta.1. One of his comments touched upon the potentially misleading behavior of the
getCurrentProxy
function in the situation when the proxy owner transfers ownership viatransferOwnership
. In this case,getCurrentProxy
would return an invalid and misleading address, because the proxy would no longer belong to the providedowner
.It is impossible to prevent this scenario under the current architecture (there is no communication channel between proxies and registry, and, for security reasons, there shouldn't be any).
Proposal
This issue would be eradicated if the registry and the factory contracts were merged into a single contract that wouldn't allow users to deploy multiple proxies. The
transferOwnership
function in the proxy would be moved to this merged contract.Pros
getCurrentProxy
reported by @razgrafCons
CREATE2
address computationDeployProxy.s.sol
script.Beta Was this translation helpful? Give feedback.
All reactions