Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide "computeProxyAddress" util #93

Open
PaulRBerg opened this issue May 3, 2023 · 2 comments
Open

Provide "computeProxyAddress" util #93

PaulRBerg opened this issue May 3, 2023 · 2 comments
Labels
effort: high Large or difficult task. good first issue Good for newcomers. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Owner

The computeProxyAddress is currently available only internally, via the Base_Test contract. I should make it publicly available via a Utils.sol file under test/utils.
@PaulRBerg PaulRBerg added good first issue Good for newcomers. effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. and removed testing labels Jan 1, 2024
@wiasliaw
Copy link

What if move computeProxyAddress, deployRegistryConditionally, getProxyBytecode, isTestOptimizedProfile to test/utils/DeployOptimized.sol?

@PaulRBerg
Copy link
Owner Author

PaulRBerg commented Feb 22, 2024 •
edited
Loading

DeployOptimized is for deployment helpers. The functions you have mentioned serve different purposes (testing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: high Large or difficult task. good first issue Good for newcomers. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulRBerg @wiasliaw