Ignore all notification after COMPLETED

PayU-EMEA · May 15, 2017 · 1647ce8 · 1647ce8
1 parent 0f672e0
commit 1647ce8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/upload/catalog/controller/extension/payment/payu.php b/upload/catalog/controller/extension/payment/payu.php
@@ -117,12 +117,14 @@ public function ordernotify()
                         $orderRetrive->getError() . ' [response: ' . serialize($orderRetrive->getResponse()) . ']'
                     );
                 } else {
+                    $payuOrderStatus = $orderRetrive->getResponse()->orders[0]->status;
+                    $order = $this->model_checkout_order->getOrder($orderInfo['order_id']);
 
                     if ($orderInfo['status'] != OpenPayuOrderStatus::STATUS_COMPLETED) {
-                        $newstatus = $this->getPaymentStatusId($orderRetrive->getResponse()->orders[0]->status);
+                        $newstatus = $this->getPaymentStatusId($payuOrderStatus);
 
-                        if ($newstatus && $newstatus != $orderInfo['status']) {
-                            $this->model_extension_payment_payu->updateSatatus($session_id, $newstatus);
+                        if ($newstatus && $newstatus != $order['order_status']) {
+                            $this->model_extension_payment_payu->updateSatatus($session_id, $payuOrderStatus);
                             $this->model_checkout_order->addOrderHistory($orderInfo['order_id'], $newstatus);
                         }
 
@@ -132,6 +134,7 @@ public function ordernotify()
 
         } catch (OpenPayU_Exception $e) {
             $this->logger->write('OCR Notification: ' . $e->getMessage());
+            die($e->getMessage());
         }
 
     }

diff --git a/upload/catalog/model/extension/payment/payu.php b/upload/catalog/model/extension/payment/payu.php
@@ -43,7 +43,7 @@ public function getMethod($address, $total)
 
     public function bindOrderIdAndSessionId($orderId, $sessionId)
     {
-        $query = 'INSERT INTO ' . DB_PREFIX . 'payu_so VALUES (NULL, "'.(int)$orderId.'", "'.$this->db->escape($sessionId).'", 1)';
+        $query = 'INSERT INTO ' . DB_PREFIX . 'payu_so VALUES (NULL, "'.(int)$orderId.'", "'.$this->db->escape($sessionId).'", "'.OpenPayuOrderStatus::STATUS_PENDING.'")';
         return $this->db->query($query);
     }