Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any alternative to get the fonts and icons from elements framework instead of getting them copied manually #200

Open
dinukadesilva opened this issue May 8, 2017 · 1 comment

Comments

@dinukadesilva
Copy link
Contributor

No description provided.

@StommePoes
Copy link
Contributor

StommePoes commented May 8, 2017

We've been looking into having an external CDN URL for the fonts.

One problem with the icons is they're SVG and for both IE and a certain set of older webkit-based Android browsers we still support, the SVGs have to be placed on the page they're used. That can be done manually to your HTML page but if you use the Javascript (mentioned in Elements on the Icons page), you would have to change that URL to the CDN.

Which is doable, but I was hoping for a way to have that JS be able to grab the svg sprite file even if it doesn't exactly know its name or the full path.

Also currently both the fonts and svgs are fingerprinted-- we'll likely get rid of fingerprinting for the fonts, they're very unlikely to change much. So in our Jira we do have a story for getting rid of that and because it's gulp we figured we'd might as well move Elements over the webpack 2 as well (so everything uses the same tech stack).

I'll tag this issue number to that ticket, it's a good idea. https://agile-jira.pearson.com/browse/DES-216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants