Enveloped signature xpath #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tures This change fixes a case where an overly-general XPath expression would find all instances of ds:Signature nodes wherever they appeared, which would make nested signing impossible. Nested signing, where some node inside the document is signed, and then the entire document also gets a signature which includes the node's signature, is commonly used with SAML, where the Assertion is signed first, and then the Response (root node) that contains the Assertion must also be signed. This bug was causing the contained Signature to be stripped, resulting in invalid digest values.
|
@rkaw92 Thank you for your PR. I published a new version of xmldsig. It fixes that problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents eating up nested Signature nodes when doing double signing: one for a node inside the document, and another signature that encapsulates the document with the signed node. This is a common scenario for SAML 2.0, where the Assertion is signed first, and then the containing root node is also signed.
Fixes #37