Problem: Publishing fails silently when client is reconnecting and #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offline queues are disabled. Fix: Allow application to handle republishing of failed messages OR enable offline queues by throwing an exception under these conditions.
sunilpalacherla
changed the title
kevinbpeel
reviewed
Mar 22, 2018
| @@ -1174,6 +1174,8 @@ public void publishData(byte[] data, String topic, AWSIotMqttQos qos, | |||
| AWSIotMqttMessageDeliveryCallback.MessageDeliveryStatus.Fail, | |||
| userData); | |||
| } | |||
| } else { | |||
| throw new AmazonClientException("Client is reconnecting and publishing from offline queue is disabled."); | |||
There was a problem hiding this comment.
This covers the case where a message is dropped where offlinePublishQueueEnabled is false.
What do you think about line 1171? It seems that putMessageInQueue, could return true and drop a message if fullQueueKeepsOldest is false. It seems it will drop the oldest message silently and return true. Perhaps this does not affect our use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offline queues are disabled.
Fix: Allow application to handle republishing of failed messages OR
enable offline queues by throwing an exception under these conditions.