checking if behavior same if no workers started

PeerDB-io · Feb 29, 2024 · 12b94f7 · 12b94f7
1 parent 462d211
commit 12b94f7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 18 deletions.
diff --git a/flow/e2e/main.go b/flow/e2e/main.go
@@ -14,24 +14,26 @@ import (
 func TestMain(m *testing.M) {
 	end := make(chan interface{})
 	group, _ := errgroup.WithContext(context.Background())
-	group.Go(func() error {
-		return cmd.WorkerMain(end, &cmd.WorkerOptions{
-			TemporalHostPort:  "localhost:7233",
-			EnableProfiling:   false,
-			PyroscopeServer:   "",
-			TemporalNamespace: "default",
-			TemporalCert:      "",
-			TemporalKey:       "",
+	/*
+		group.Go(func() error {
+			return cmd.WorkerMain(end, &cmd.WorkerOptions{
+				TemporalHostPort:  "localhost:7233",
+				EnableProfiling:   false,
+				PyroscopeServer:   "",
+				TemporalNamespace: "default",
+				TemporalCert:      "",
+				TemporalKey:       "",
+			})
 		})
-	})
-	group.Go(func() error {
-		return cmd.SnapshotWorkerMain(end, &cmd.SnapshotWorkerOptions{
-			TemporalHostPort:  "localhost:7233",
-			TemporalNamespace: "default",
-			TemporalCert:      "",
-			TemporalKey:       "",
+		group.Go(func() error {
+			return cmd.SnapshotWorkerMain(end, &cmd.SnapshotWorkerOptions{
+				TemporalHostPort:  "localhost:7233",
+				TemporalNamespace: "default",
+				TemporalCert:      "",
+				TemporalKey:       "",
+			})
 		})
-	})
+	*/
 	exitcode := m.Run()
 	close(end)
 	err := group.Wait()

diff --git a/flow/e2e/test_utils.go b/flow/e2e/test_utils.go
@@ -647,7 +647,10 @@ func EnvWaitForFinished(t *testing.T, env WorkflowRun, timeout time.Duration) {
 			return false
 		}
 		status := desc.GetWorkflowExecutionInfo().GetStatus()
-		t.Log("Finished Status", status)
-		return status != enums.WORKFLOW_EXECUTION_STATUS_RUNNING
+		if status != enums.WORKFLOW_EXECUTION_STATUS_RUNNING {
+			t.Log("Finished Status", status)
+			return true
+		}
+		return false
 	})
 }