From 19da0fbb568032612a0cf07b8f11a136d45b9015 Mon Sep 17 00:00:00 2001 From: Amogh Bharadwaj Date: Thu, 11 Jan 2024 23:42:54 +0530 Subject: [PATCH] Eventhub: fix logs and metadatadb requirement (#1055) Removes metadatadb requirement for Eventhub Group peer as it can use catalog on its own Fixes a few logs --- flow/connectors/eventhub/eventhub.go | 4 ++-- nexus/analyzer/src/lib.rs | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/flow/connectors/eventhub/eventhub.go b/flow/connectors/eventhub/eventhub.go index af5c008ad1..072044d787 100644 --- a/flow/connectors/eventhub/eventhub.go +++ b/flow/connectors/eventhub/eventhub.go @@ -71,7 +71,7 @@ func (c *EventHubConnector) Close() error { err = c.hubManager.Close(context.Background()) if err != nil { - slog.Error("failed to close event hub manager", slog.Any("error", err)) + c.logger.Error("failed to close event hub manager", slog.Any("error", err)) allErrors = errors.Join(allErrors, err) } @@ -240,7 +240,7 @@ func (c *EventHubConnector) SyncRecords(req *model.SyncRecordsRequest) (*model.S lastCheckpoint, err := req.Records.GetLastCheckpoint() if err != nil { - c.logger.Error("failed to get last checkpoint", err) + c.logger.Error("failed to get last checkpoint", slog.Any("error", err)) return nil, err } diff --git a/nexus/analyzer/src/lib.rs b/nexus/analyzer/src/lib.rs index bbbbf531d8..8a9fcf9615 100644 --- a/nexus/analyzer/src/lib.rs +++ b/nexus/analyzer/src/lib.rs @@ -749,11 +749,6 @@ fn parse_db_options( let conn_str = opts.get("metadata_db"); let metadata_db = parse_metadata_db_info(conn_str.copied())?; - // metadata_db is required for eventhub group - if metadata_db.is_none() { - anyhow::bail!("metadata_db is required for eventhub group"); - } - // split comma separated list of columns and trim let unnest_columns = opts .get("unnest_columns")