From 325bb89ed82b47b96d9357047acf122a3ca6699e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20Dub=C3=A9?= Date: Fri, 22 Dec 2023 19:08:27 +0000 Subject: [PATCH] Pulling my hair out trying to figure out why this pool is closed --- flow/e2e/congen.go | 11 ++--------- flow/e2e/snowflake/peer_flow_sf_test.go | 1 - 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/flow/e2e/congen.go b/flow/e2e/congen.go index cce1f5fef6..c063b9a174 100644 --- a/flow/e2e/congen.go +++ b/flow/e2e/congen.go @@ -136,15 +136,8 @@ func SetupPostgres(suffix string) (*pgxpool.Pool, error) { } func TearDownPostgres(pool *pgxpool.Pool, suffix string) error { - // drop the e2e_test schema - if pool != nil { - err := cleanPostgres(pool, suffix) - if err != nil { - return err - } - pool.Close() - } - return nil + err := cleanPostgres(pool, suffix) + return err } // GeneratePostgresPeer generates a postgres peer config for testing. diff --git a/flow/e2e/snowflake/peer_flow_sf_test.go b/flow/e2e/snowflake/peer_flow_sf_test.go index 0d84e35b82..5b9b53ea87 100644 --- a/flow/e2e/snowflake/peer_flow_sf_test.go +++ b/flow/e2e/snowflake/peer_flow_sf_test.go @@ -85,7 +85,6 @@ func setupSuite(t *testing.T) PeerFlowE2ETestSuiteSF { return suite } -// Implement TearDownAllSuite interface to tear down the test suite func (s PeerFlowE2ETestSuiteSF) TearDownSuite() { err := e2e.TearDownPostgres(s.pool, s.pgSuffix) if err != nil {