From 44ab4c426875a7f33e36badcc5ee551a5508503a Mon Sep 17 00:00:00 2001 From: Amogh-Bharadwaj Date: Thu, 16 Nov 2023 23:04:52 +0530 Subject: [PATCH] fix log and style --- flow/connectors/external_metadata/store.go | 1 - flow/connectors/s3/s3.go | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/flow/connectors/external_metadata/store.go b/flow/connectors/external_metadata/store.go index 25ed960fee..8693dabb58 100644 --- a/flow/connectors/external_metadata/store.go +++ b/flow/connectors/external_metadata/store.go @@ -24,7 +24,6 @@ type PostgresMetadataStore struct { func NewPostgresMetadataStore(ctx context.Context, pgConfig *protos.PostgresConfig, schemaName string) (*PostgresMetadataStore, error) { connectionString := utils.GetPGConnectionString(pgConfig) - log.Info("connection string in external metadata: ", connectionString) pool, err := pgxpool.New(ctx, connectionString) if err != nil { log.Errorf("failed to create connection pool: %v", err) diff --git a/flow/connectors/s3/s3.go b/flow/connectors/s3/s3.go index f8f0898585..c9fcf5a47a 100644 --- a/flow/connectors/s3/s3.go +++ b/flow/connectors/s3/s3.go @@ -93,15 +93,14 @@ func (c *S3Connector) Close() error { return nil } -func ValidCheck(s3Client *s3.S3, bucketUrl string, metadataDB *metadataStore.PostgresMetadataStore) error { +func ValidCheck(s3Client *s3.S3, bucketURL string, metadataDB *metadataStore.PostgresMetadataStore) error { _, listErr := s3Client.ListBuckets(nil) if listErr != nil { return fmt.Errorf("failed to list buckets: %w", listErr) } reader := strings.NewReader("hello world") - - bucketPrefix, parseErr := utils.NewS3BucketAndPrefix(bucketUrl) + bucketPrefix, parseErr := utils.NewS3BucketAndPrefix(bucketURL) if parseErr != nil { return fmt.Errorf("failed to parse bucket url: %w", parseErr) }