From 4ee655166f788b28452a0d6c5c7aa52c09c33379 Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Fri, 8 Dec 2023 14:30:27 -0500 Subject: [PATCH] fix comments and one more test --- flow/e2e/bigquery/peer_flow_bq_test.go | 1 - flow/e2e/bigquery/qrep_flow_bq_test.go | 1 - flow/e2e/postgres/qrep_flow_pg_test.go | 1 - flow/e2e/snowflake/qrep_flow_sf_test.go | 2 -- 4 files changed, 5 deletions(-) diff --git a/flow/e2e/bigquery/peer_flow_bq_test.go b/flow/e2e/bigquery/peer_flow_bq_test.go index bc06b4dc7a..559f03ba62 100644 --- a/flow/e2e/bigquery/peer_flow_bq_test.go +++ b/flow/e2e/bigquery/peer_flow_bq_test.go @@ -132,7 +132,6 @@ func (s PeerFlowE2ETestSuiteBQ) Test_Invalid_Connection_Config() { err := env.GetWorkflowError() // assert that error contains "invalid connection configs" - s.Error(err) require.Contains(s.t, err.Error(), "invalid connection configs") env.AssertExpectations(s.t) diff --git a/flow/e2e/bigquery/qrep_flow_bq_test.go b/flow/e2e/bigquery/qrep_flow_bq_test.go index 31becd0b48..c12634cec8 100644 --- a/flow/e2e/bigquery/qrep_flow_bq_test.go +++ b/flow/e2e/bigquery/qrep_flow_bq_test.go @@ -71,7 +71,6 @@ func (s PeerFlowE2ETestSuiteBQ) Test_Complete_QRep_Flow_Avro() { // Verify workflow completes without error s.True(env.IsWorkflowCompleted()) - // assert that error contains "invalid connection configs" err = env.GetWorkflowError() require.NoError(s.t, err) diff --git a/flow/e2e/postgres/qrep_flow_pg_test.go b/flow/e2e/postgres/qrep_flow_pg_test.go index 5326a58e3d..c9b82a4c6c 100644 --- a/flow/e2e/postgres/qrep_flow_pg_test.go +++ b/flow/e2e/postgres/qrep_flow_pg_test.go @@ -175,7 +175,6 @@ func (s *PeerFlowE2ETestSuitePG) Test_Complete_QRep_Flow_Multi_Insert_PG() { // Verify workflow completes without error s.True(env.IsWorkflowCompleted()) - // assert that error contains "invalid connection configs" err = env.GetWorkflowError() s.NoError(err) diff --git a/flow/e2e/snowflake/qrep_flow_sf_test.go b/flow/e2e/snowflake/qrep_flow_sf_test.go index 1aca83171f..81884d2e3d 100644 --- a/flow/e2e/snowflake/qrep_flow_sf_test.go +++ b/flow/e2e/snowflake/qrep_flow_sf_test.go @@ -86,7 +86,6 @@ func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF() { // Verify workflow completes without error s.True(env.IsWorkflowCompleted()) - // assert that error contains "invalid connection configs" err = env.GetWorkflowError() require.NoError(s.t, err) @@ -130,7 +129,6 @@ func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_Upsert_Simple() // Verify workflow completes without error s.True(env.IsWorkflowCompleted()) - // assert that error contains "invalid connection configs" err = env.GetWorkflowError() require.NoError(s.t, err)