UI: filter out no canMirror (#1394)

Fixes a bug with select all where not mirrorable tables are included
PeerDB-io · Feb 28, 2024 · 69c6f34 · 69c6f34
1 parent a8a1f47
commit 69c6f34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ui/app/mirrors/create/cdc/schemabox.tsx b/ui/app/mirrors/create/cdc/schemabox.tsx
@@ -128,7 +128,7 @@ const SchemaBox = ({
     const newRows = [...rows];
     for (let i = 0; i < newRows.length; i++) {
       const row = newRows[i];
-      if (row.schema === schemaName) {
+      if (row.schema === schemaName && row.canMirror) {
         newRows[i] = { ...row, selected: e.currentTarget.checked };
         if (e.currentTarget.checked) addTableColumns(row.source);
         else removeTableColumns(row.source);

diff --git a/ui/app/mirrors/create/handlers.ts b/ui/app/mirrors/create/handlers.ts
@@ -122,7 +122,7 @@ export const reformattedTableMapping = (
   tableMapping: TableMapRow[]
 ): TableMapping[] => {
   const mapping = tableMapping
-    .filter((row) => row?.selected === true)
+    .filter((row) => row?.selected === true && row?.canMirror === true)
     .map((row) => ({
       sourceTableIdentifier: row.source,
       destinationTableIdentifier: row.destination,