From 74af1b8f7280c38e54aad3fd4b53b91fb56e8ee4 Mon Sep 17 00:00:00 2001 From: Kevin Biju Date: Wed, 6 Dec 2023 11:50:03 +0530 Subject: [PATCH] fixed more comments, and nolint --- flow/connectors/utils/cdc_records/cdc_records_storage.go | 3 ++- flow/connectors/utils/cdc_records/cdc_records_storage_test.go | 1 + flow/model/qvalue/qvalue.go | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/flow/connectors/utils/cdc_records/cdc_records_storage.go b/flow/connectors/utils/cdc_records/cdc_records_storage.go index 1449a489c7..7c87f2a99a 100644 --- a/flow/connectors/utils/cdc_records/cdc_records_storage.go +++ b/flow/connectors/utils/cdc_records/cdc_records_storage.go @@ -1,3 +1,4 @@ +//nolint:stylecheck package cdc_records import ( @@ -19,7 +20,7 @@ const ( /** begin with in-memory store, and then switch to Pebble DB when the number of stored records crosses 1M **/ - defaultNumRecordsSwitchThreshold = 0 + defaultNumRecordsSwitchThreshold = 1_000_000 ) func encVal(val any) ([]byte, error) { diff --git a/flow/connectors/utils/cdc_records/cdc_records_storage_test.go b/flow/connectors/utils/cdc_records/cdc_records_storage_test.go index 8bd804f9a3..f3495666d1 100644 --- a/flow/connectors/utils/cdc_records/cdc_records_storage_test.go +++ b/flow/connectors/utils/cdc_records/cdc_records_storage_test.go @@ -1,3 +1,4 @@ +//nolint:stylecheck package cdc_records import ( diff --git a/flow/model/qvalue/qvalue.go b/flow/model/qvalue/qvalue.go index 8a67ae7b88..050945df37 100644 --- a/flow/model/qvalue/qvalue.go +++ b/flow/model/qvalue/qvalue.go @@ -12,6 +12,7 @@ import ( "github.com/google/uuid" ) +// if new types are added, register them in gob - cdc_records_storage.go type QValue struct { Kind QValueKind Value interface{}