From a9ced641947dbbd40860326a56324d1780f55b6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20Dub=C3=A9?= Date: Sat, 6 Jan 2024 03:06:06 +0000 Subject: [PATCH] column exclusion: include checking c1. debug logging this last test --- flow/e2e/bigquery/peer_flow_bq_test.go | 4 +++- flow/e2e/snowflake/peer_flow_sf_test.go | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/flow/e2e/bigquery/peer_flow_bq_test.go b/flow/e2e/bigquery/peer_flow_bq_test.go index 5a67edf1fb..d8e22c06aa 100644 --- a/flow/e2e/bigquery/peer_flow_bq_test.go +++ b/flow/e2e/bigquery/peer_flow_bq_test.go @@ -1526,7 +1526,7 @@ func (s PeerFlowE2ETestSuiteBQ) Test_Soft_Delete_UD_Same_Batch() { require.NoError(s.t, err) connectionGen := e2e.FlowConnectionGenerationConfig{ - FlowJobName: s.attachSuffix("test_softdel_ud"), + FlowJobName: s.attachSuffix(dstName), } config := &protos.FlowConnectionConfigs{ @@ -1587,6 +1587,8 @@ func (s PeerFlowE2ETestSuiteBQ) Test_Soft_Delete_UD_Same_Batch() { return false } + newrows, _ := s.GetRows(dstName, "id,c1,c2,t") + s.t.Log("rows same", rows.NumRecords, newrows.NumRecords) newerSyncedAtQuery := fmt.Sprintf( "SELECT COUNT(*) FROM `%s.%s` WHERE _PEERDB_IS_DELETED", s.bqHelper.datasetName, dstName) diff --git a/flow/e2e/snowflake/peer_flow_sf_test.go b/flow/e2e/snowflake/peer_flow_sf_test.go index 3f3e48a7f5..0319154dc7 100644 --- a/flow/e2e/snowflake/peer_flow_sf_test.go +++ b/flow/e2e/snowflake/peer_flow_sf_test.go @@ -1237,13 +1237,13 @@ func (s PeerFlowE2ETestSuiteSF) Test_Column_Exclusion() { } s.t.Log("Inserted 10 rows into the source table") - e2e.EnvWaitForEqualTables(env, s, "normalize table", tableName, "id,t,t2") + e2e.EnvWaitForEqualTables(env, s, "normalize table", tableName, "id,c1,t,t2") _, err = s.pool.Exec(context.Background(), fmt.Sprintf(`UPDATE %s SET c1=c1+1 WHERE MOD(c2,2)=1`, srcTableName)) e2e.EnvNoError(s.t, env, err) _, err = s.pool.Exec(context.Background(), fmt.Sprintf(`DELETE FROM %s WHERE MOD(c2,2)=0`, srcTableName)) e2e.EnvNoError(s.t, env, err) - e2e.EnvWaitForEqualTables(env, s, "normalize update/delete", tableName, "id,t,t2") + e2e.EnvWaitForEqualTables(env, s, "normalize update/delete", tableName, "id,c1,t,t2") env.CancelWorkflow() }()