once again I'm dealing with go's nil != nil semantics

PeerDB-io · Feb 14, 2024 · addacb2 · addacb2
1 parent d1b9b63
commit addacb2
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/flow/model/qvalue/qvalue.go b/flow/model/qvalue/qvalue.go
@@ -29,9 +29,6 @@ func (q QValue) Equals(other QValue) bool {
 		return true // TODO fix
 	} else if q.Value == nil && other.Value == nil {
 		return true
-	} else if !q.Kind.IsArray() && q.Kind != QValueKindBytes &&
-		(q.Value == nil) != (other.Value == nil) {
-		return false
 	}
 
 	switch q.Kind {
@@ -237,10 +234,6 @@ func compareBytes(value1, value2 interface{}) bool {
 }
 
 func compareNumeric(value1, value2 interface{}) bool {
-	if value1 == nil && value2 == nil {
-		return true
-	}
-
 	rat1, ok1 := getRat(value1)
 	rat2, ok2 := getRat(value2)