From addacb26eed72eba2f0dab646295c25a78ceee41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20Dub=C3=A9?= Date: Wed, 14 Feb 2024 19:40:36 +0000 Subject: [PATCH] once again I'm dealing with go's nil != nil semantics --- flow/model/qvalue/qvalue.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/flow/model/qvalue/qvalue.go b/flow/model/qvalue/qvalue.go index 93b9ac8b7f..1ad07150b6 100644 --- a/flow/model/qvalue/qvalue.go +++ b/flow/model/qvalue/qvalue.go @@ -29,9 +29,6 @@ func (q QValue) Equals(other QValue) bool { return true // TODO fix } else if q.Value == nil && other.Value == nil { return true - } else if !q.Kind.IsArray() && q.Kind != QValueKindBytes && - (q.Value == nil) != (other.Value == nil) { - return false } switch q.Kind { @@ -237,10 +234,6 @@ func compareBytes(value1, value2 interface{}) bool { } func compareNumeric(value1, value2 interface{}) bool { - if value1 == nil && value2 == nil { - return true - } - rat1, ok1 := getRat(value1) rat2, ok2 := getRat(value2)