Skip to content

Commit cb827bf

Browse files
committed
investigating why rows aren't same, probably some thread safety issue
1 parent 949efa8 commit cb827bf

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/flow.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ jobs:
9393

9494
- name: run tests
9595
run: |
96-
gotestsum --format testname -- -p 4 ./... -timeout 2400s
96+
gotestsum --format testname -- -p 4 ./e2e/snowflake/... -timeout 2400s
9797
working-directory: ./flow
9898
env:
9999
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}

flow/e2e/snowflake/peer_flow_sf_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ func (s *PeerFlowE2ETestSuiteSF) Test_Toast_SF(t *testing.T) {
388388
Executing a transaction which
389389
1. changes both toast column
390390
2. changes no toast column
391-
2. changes 1 toast column
391+
3. changes 1 toast column
392392
*/
393393
_, err = s.pool.Exec(context.Background(), fmt.Sprintf(`
394394
BEGIN;

flow/e2e/snowflake/qrep_flow_sf_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ func (s *PeerFlowE2ETestSuiteSF) compareTableContentsSF(t *testing.T, tableName
5454
sfRows, err := s.sfHelper.ExecuteAndProcessQuery(sfSelQuery)
5555
require.NoError(t, err)
5656

57+
t.Logf("compare %v = %v", pgRows, sfRows)
58+
5759
assert.True(t, pgRows.Equals(sfRows), "rows from source and destination tables are not equal")
5860
}
5961

@@ -243,7 +245,7 @@ func (s *PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_S3_Integration(
243245
query := fmt.Sprintf("SELECT * FROM e2e_test_%s.%s WHERE updated_at BETWEEN {{.start}} AND {{.end}}",
244246
snowflakeSuffix, tblName)
245247

246-
sfPeer := s.sfHelper.Peer
248+
sfPeer := s.sfHelper.Peer // TODO clone
247249
sfPeer.GetSnowflakeConfig().S3Integration = "peerdb_s3_integration"
248250

249251
qrepConfig, err := e2e.CreateQRepWorkflowConfig(

0 commit comments

Comments
 (0)