From cd60e3f3f94c2b24b069d6f555e986dc42f4cab9 Mon Sep 17 00:00:00 2001
From: Amogh Bharadwaj <amogh@peerdb.io>
Date: Wed, 6 Dec 2023 00:39:41 +0530
Subject: [PATCH] Minor UI improvements  (#757)

Fixes #751
---
 ui/app/mirrors/create/cdc/schemabox.tsx       |  1 +
 ui/app/mirrors/create/schema.ts               | 19 +++++++++++--------
 .../mirrors/edit/[mirrorId]/configValues.ts   | 10 +++++-----
 3 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/ui/app/mirrors/create/cdc/schemabox.tsx b/ui/app/mirrors/create/cdc/schemabox.tsx
index 5a40092ca2..e205f33ab5 100644
--- a/ui/app/mirrors/create/cdc/schemabox.tsx
+++ b/ui/app/mirrors/create/cdc/schemabox.tsx
@@ -270,6 +270,7 @@ const SchemaBox = ({
                                   }
                                   action={
                                     <Checkbox
+                                      style={{ cursor: 'pointer' }}
                                       disabled={isPkey}
                                       checked={
                                         !row.exclude.find(
diff --git a/ui/app/mirrors/create/schema.ts b/ui/app/mirrors/create/schema.ts
index 19f2eaeb28..bb892b3d9d 100644
--- a/ui/app/mirrors/create/schema.ts
+++ b/ui/app/mirrors/create/schema.ts
@@ -152,14 +152,17 @@ export const qrepSchema = z.object({
     })
     .max(255, 'Staging path must be less than 255 characters')
     .optional(),
-  writeMode: z.object({
-    writeType: z
-      .number({ required_error: 'Write type is required' })
-      .int()
-      .min(0)
-      .max(2),
-    upsert_key_columns: z.array(z.string()).optional(),
-  }),
+  writeMode: z.object(
+    {
+      writeType: z
+        .number({ required_error: 'Write type is required' })
+        .int()
+        .min(0)
+        .max(2),
+      upsert_key_columns: z.array(z.string()).optional(),
+    },
+    { required_error: 'Write mode is required' }
+  ),
   waitBetweenBatchesSeconds: z
     .number({
       invalid_type_error: 'Batch wait must be a number',
diff --git a/ui/app/mirrors/edit/[mirrorId]/configValues.ts b/ui/app/mirrors/edit/[mirrorId]/configValues.ts
index 7f5172d1cd..76d4982910 100644
--- a/ui/app/mirrors/edit/[mirrorId]/configValues.ts
+++ b/ui/app/mirrors/edit/[mirrorId]/configValues.ts
@@ -1,10 +1,10 @@
 import { FlowConnectionConfigs, QRepSyncMode } from '@/grpc_generated/flow';
 
 const syncModeToLabel = (mode: QRepSyncMode) => {
-  switch (mode) {
-    case QRepSyncMode.QREP_SYNC_MODE_STORAGE_AVRO:
+  switch (mode.toString()) {
+    case 'QREP_SYNC_MODE_STORAGE_AVRO':
       return 'AVRO';
-    case QRepSyncMode.QREP_SYNC_MODE_MULTI_INSERT:
+    case 'QREP_SYNC_MODE_MULTI_INSERT':
       return 'Copy with Binary';
     default:
       return 'AVRO';
@@ -29,11 +29,11 @@ const MirrorValues = (mirrorConfig: FlowConnectionConfigs | undefined) => {
       label: 'Snapshot Parallel Tables',
     },
     {
-      value: `${syncModeToLabel(mirrorConfig?.cdcSyncMode!)} mode`,
+      value: `${syncModeToLabel(mirrorConfig?.cdcSyncMode!)}`,
       label: 'CDC Sync Mode',
     },
     {
-      value: `${syncModeToLabel(mirrorConfig?.snapshotSyncMode!)} mode`,
+      value: `${syncModeToLabel(mirrorConfig?.snapshotSyncMode!)}`,
       label: 'Snapshot Sync Mode',
     },
     {