Skip to content

Commit

Permalink
Better COPY command quoting (#526)
Browse files Browse the repository at this point in the history
  • Loading branch information
Amogh-Bharadwaj authored Oct 17, 2023
1 parent 2aa285e commit d07b78d
Showing 1 changed file with 7 additions and 14 deletions.
21 changes: 7 additions & 14 deletions flow/connectors/snowflake/qrep_avro_sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,31 +265,24 @@ func (sc *SnowflakeConnector) GetCopyTransformation(dstTableName string) (*CopyI

var transformations []string
var columnOrder []string
for col, colType := range colInfo.ColumnMap {
if col == "_PEERDB_IS_DELETED" {
for colName, colType := range colInfo.ColumnMap {
if colName == "_PEERDB_IS_DELETED" {
continue
}
colName := strings.ToLower(col)
// No need to quote raw table columns
if strings.Contains(dstTableName, "_PEERDB_RAW") {
columnOrder = append(columnOrder, colName)
} else {
columnOrder = append(columnOrder, fmt.Sprintf("\"%s\"", colName))
}

columnOrder = append(columnOrder, fmt.Sprintf("\"%s\"", colName))
switch colType {
case "GEOGRAPHY":
transformations = append(transformations,
fmt.Sprintf("TO_GEOGRAPHY($1:\"%s\"::string) AS \"%s\"", colName, colName))
fmt.Sprintf("TO_GEOGRAPHY($1:\"%s\"::string, true) AS \"%s\"", strings.ToLower(colName), colName))
case "GEOMETRY":
transformations = append(transformations,
fmt.Sprintf("TO_GEOMETRY($1:\"%s\"::string) AS \"%s\"", colName, colName))
fmt.Sprintf("TO_GEOMETRY($1:\"%s\"::string, true) AS \"%s\"", strings.ToLower(colName), colName))
case "NUMBER":
transformations = append(transformations,
fmt.Sprintf("$1:\"%s\" AS \"%s\"", colName, colName))
fmt.Sprintf("$1:\"%s\" AS \"%s\"", strings.ToLower(colName), colName))
default:
transformations = append(transformations,
fmt.Sprintf("($1:\"%s\")::%s AS \"%s\"", colName, colType, colName))
fmt.Sprintf("($1:\"%s\")::%s AS \"%s\"", strings.ToLower(colName), colType, colName))
}
}
transformationSQL := strings.Join(transformations, ",")
Expand Down

0 comments on commit d07b78d

Please sign in to comment.