Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed Metrics with Catalog Monitoring Data Instead #405

Closed
Amogh-Bharadwaj opened this issue Sep 21, 2023 · 1 comment
Closed

Feed Metrics with Catalog Monitoring Data Instead #405

Amogh-Bharadwaj opened this issue Sep 21, 2023 · 1 comment
Assignees

Comments

@Amogh-Bharadwaj
Copy link
Contributor

Right now our mirror code has steps in it for collecting data to show on Grafana. We also collect data to store for our native catalog metrics. There is some redundancy here, potentially slowing the flow down a bit.

Instead, we can just use the data we collect for catalog peerdb_stats and provide it to metrics.go.
For example, to get total records at target we could do:

select sum(num_rows) from peerdb_stats.cdc_batch_table;
@Amogh-Bharadwaj Amogh-Bharadwaj self-assigned this Sep 21, 2023
@heavycrystal
Copy link
Contributor

Grafana metrics removed in #703, therefore this is unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants