Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avro converter typo #847

Closed
serprex opened this issue Dec 18, 2023 · 1 comment
Closed

Fix avro converter typo #847

serprex opened this issue Dec 18, 2023 · 1 comment
Assignees

Comments

@serprex
Copy link
Contributor

serprex commented Dec 18, 2023

case QValueKindHStore, QValueKindJSON, QValueKindStruct:
return &QValueKindAvroSchema{
AvroLogicalSchema: map[string]interface{}{
"type": "string",
"values": "string",
},
}, nil

https://avro.apache.org/docs/1.11.0/spec.html#Maps

If hstore/json/struct should be encoded as string, AvroLogicalSchema should only be "string"

As is, it looks like the intent of the code is to be a map, but then "type" should be "map"

@serprex
Copy link
Contributor Author

serprex commented Dec 18, 2023

If type being string is correct, #846 fixes this

@serprex serprex closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants