CDC: Check for existing table in PG, SF, BQ #756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -738,20 +766,23 @@ func (c *SnowflakeConnector) SyncFlowCleanup(jobName string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *SnowflakeConnector) checkIfTableExists(schemaIdentifier string, tableIdentifier string) (bool, error) { | |||
| rows, err := c.database.QueryContext(c.ctx, checkIfTableExistsSQL, schemaIdentifier, tableIdentifier) | |||
| func (c *SnowflakeConnector) checkIfTableExists(schemaIdentifier string, tableIdentifier string) ([]protos.TableColumn, error) { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 128 characters (lll)
flow/connectors/bigquery/bigquery.go
Outdated
| return nil, fmt.Errorf("destination column %s not found in source: ", existingField.Name) | ||
| } | ||
| if existingField.Name != desiredField.Name || existingField.Type != desiredField.Type { | ||
| return nil, fmt.Errorf("failed to setup normalized table due to incompatible columns: %s (destination) and %s (source)", |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 140 characters (lll)
flow/connectors/bigquery/bigquery.go
Outdated
| return nil, fmt.Errorf("destination column %s not found in source: ", existingField.Name) | ||
| } | ||
| if existingField.Name != desiredField.Name || existingField.Type != desiredField.Type { | ||
| return nil, fmt.Errorf("failed to setup normalized table due to incompatible columns: %s (destination) and %s (source)", |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
line is 140 characters (lll)
Amogh-Bharadwaj
force-pushed
the
check-existing-table
branch
from
e3f59f7 to
0f419c0
Compare
|
This feature is more complicated than originally pipelined due to newer features related to PeerDB columns, schema changes and so on. Closing with the aim of building this check on top of a newer PeerDB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now check if an existing destination table with the same name as the source table has the same schema as the source (ignoring _PEERDB columns we create for snowflake mirrors)
Fixes #256