Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Log errors on server side API calls #803

Merged
merged 4 commits into from
Dec 12, 2023
Merged

UI: Log errors on server side API calls #803

merged 4 commits into from
Dec 12, 2023

Conversation

Amogh-Bharadwaj
Copy link
Contributor

@Amogh-Bharadwaj Amogh-Bharadwaj commented Dec 12, 2023 •
edited
Loading

For more visibility, this PR:

  • Catches server side API call errors and logs them
  • Ensures relevant GRPC APIs (create cdc, create qrep, drop mirror) are well logged too
  • All errors from the Create Peer and Validate Peer GRPC functions are captured by the frontend so I'm not logging there for now

@iskakaushik iskakaushik merged commit 36cc29f into main Dec 12, 2023
12 checks passed
@serprex serprex deleted the api-err-handle branch July 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serprex serprex serprex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amogh-Bharadwaj @serprex @iskakaushik