Skip to content

Commit

Permalink
Remove redundant asset preload (glitch-soc#2488)
Browse files Browse the repository at this point in the history
* Remove redundant asset preload

preloading these is already handled by glitch-soc theming system, meaning glitch packs get preloaded and if the user is signed in, vanilla packs.

The theming system preloads these unconditionally though.

Signed-off-by: Plastikmensch <[email protected]>

* Remove preload of getting started

This matches upstreams preloads

Signed-off-by: Plastikmensch <[email protected]>

---------

Signed-off-by: Plastikmensch <[email protected]>
  • Loading branch information
Plastikmensch authored and Rezha Julio committed Dec 5, 2023
1 parent 4306b24 commit b77fb02
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion app/javascript/flavours/glitch/theme.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ pack:
filename: packs/home.js
preload:
- flavours/glitch/async/compose
- flavours/glitch/async/getting_started
- flavours/glitch/async/home_timeline
- flavours/glitch/async/notifications
mailer:
Expand Down
1 change: 0 additions & 1 deletion app/javascript/flavours/vanilla/theme.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ pack:
home:
filename: application.js
preload:
- features/getting_started
- features/compose
- features/home_timeline
- features/notifications
Expand Down
3 changes: 0 additions & 3 deletions app/views/shared/_web_app.html.haml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
- content_for :header_tags do
- if user_signed_in?
= preload_pack_asset 'features/compose.js'
= preload_pack_asset 'features/home_timeline.js'
= preload_pack_asset 'features/notifications.js'
%meta{ name: 'initialPath', content: request.path }

%meta{ name: 'applicationServerKey', content: Rails.configuration.x.vapid_public_key }
Expand Down

0 comments on commit b77fb02

Please sign in to comment.