Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be better to load images that are “in view” and “visible”? #13

Open
rmariuzzo opened this issue Nov 26, 2015 · 4 comments
Open

Should be better to load images that are “in view” and “visible”? #13

rmariuzzo opened this issue Nov 26, 2015 · 4 comments

Comments

@rmariuzzo
Copy link

I have the following scenario: a page with thousands of images distributed in tenths of nested <li>s. By default, these <li>s are hidden, but “in view” because its parent element (<ul>) is.

I think instead of only loading images that are “in view” we should also constraint to those that are “visible”.

What do you think?
@Pentiado
Copy link
Owner

Yeah, I agree. It totally makes sense. I'm overwhelmed with amount of tasks that I took at work right now but during Christmas break I will have some time to look at it.

@rmariuzzo
Copy link
Author

Cool! I have made some changes on a separate branch, I will propose a PR for it.

@jup31
Copy link
Contributor

jup31 commented Mar 29, 2016

Had you prupose your modifications on PR ?

@daangeerdink
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmariuzzo @daangeerdink @Pentiado @jup31